Re: [PATCH v2 1/3] arm64: dts: ti: k3-j721e-evm: Add overlay for PCIe NTB functionality

[Rob Herring]

On Wed, Feb 26, 2025 at 6:43 AM Siddharth Vadapalli <s-vadapalli@xxxxxx> wrote:
>
> PCIe NTB (Non-Transparent-Bridge) allows connecting the memory of
> multiple PCIe Hosts (Root-Complex). The number of such hosts is
> determined by the number of PCIe instances configured for NTB operation
> on the device which intends to enable NTB functionality. Add a device-tree
> overlay to configure PCIE0 and PCIE1 instances of PCIe on J721E EVM for NTB
> operation. This shall allow connecting the memory of two PCIe Hosts via
> PCIE0 and PCIE1 on J721E EVM.
>
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@xxxxxx>
> ---
>
> v1:
> https://patchwork.kernel.org/project/linux-arm-kernel/patch/20250202093636.2699064-2-s-vadapalli@xxxxxx/
> Changes since v1:
> - s/epf_bus/epf-bus since node names shouldn't contain underscores.
>
> Regards,
> Siddharth.
>
>  arch/arm64/boot/dts/ti/Makefile               |  4 +
>  .../boot/dts/ti/k3-j721e-evm-pcie-ntb.dtso    | 91 +++++++++++++++++++
>  2 files changed, 95 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/ti/k3-j721e-evm-pcie-ntb.dtso
>
> diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
> index 8a4bdf87e2d4..1097ab30f5a9 100644
> --- a/arch/arm64/boot/dts/ti/Makefile
> +++ b/arch/arm64/boot/dts/ti/Makefile
> @@ -102,6 +102,7 @@ dtb-$(CONFIG_ARCH_K3) += k3-j721e-beagleboneai64.dtb
>  dtb-$(CONFIG_ARCH_K3) += k3-j721e-common-proc-board-infotainment.dtbo
>  dtb-$(CONFIG_ARCH_K3) += k3-j721e-evm.dtb
>  dtb-$(CONFIG_ARCH_K3) += k3-j721e-evm-gesi-exp-board.dtbo
> +dtb-$(CONFIG_ARCH_K3) += k3-j721e-evm-pcie-ntb.dtbo
>  dtb-$(CONFIG_ARCH_K3) += k3-j721e-evm-pcie0-ep.dtbo
>  dtb-$(CONFIG_ARCH_K3) += k3-j721e-evm-pcie1-ep.dtbo
>  dtb-$(CONFIG_ARCH_K3) += k3-j721e-sk.dtb
> @@ -201,6 +202,8 @@ k3-j7200-evm-pcie1-ep-dtbs := k3-j7200-common-proc-board.dtb \
>         k3-j7200-evm-pcie1-ep.dtbo
>  k3-j721e-common-proc-board-infotainment-dtbs := k3-j721e-common-proc-board.dtb \
>         k3-j721e-common-proc-board-infotainment.dtbo
> +k3-j721e-evm-pcie-ntb-dtbs := k3-j721e-common-proc-board.dtb \
> +       k3-j721e-evm-pcie-ntb.dtbo
>  k3-j721e-evm-pcie0-ep-dtbs := k3-j721e-common-proc-board.dtb \
>         k3-j721e-evm-pcie0-ep.dtbo
>  k3-j721e-evm-pcie1-ep-dtbs := k3-j721e-common-proc-board.dtb \
> @@ -239,6 +242,7 @@ dtb- += k3-am625-beagleplay-csi2-ov5640.dtb \
>         k3-am69-sk-pcie0-ep.dtb \
>         k3-j7200-evm-pcie1-ep.dtb \
>         k3-j721e-common-proc-board-infotainment.dtb \
> +       k3-j721e-evm-pcie-ntb.dtb \
>         k3-j721e-evm-pcie0-ep.dtb \
>         k3-j721e-evm-pcie1-ep.dtb \
>         k3-j721e-sk-csi2-dual-imx219.dtb \
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-evm-pcie-ntb.dtso b/arch/arm64/boot/dts/ti/k3-j721e-evm-pcie-ntb.dtso
> new file mode 100644
> index 000000000000..9b6b3e153e91
> --- /dev/null
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-evm-pcie-ntb.dtso
> @@ -0,0 +1,91 @@
> +// SPDX-License-Identifier: GPL-2.0-only OR MIT
> +/**
> + * DT Overlay for enabling NTB functionality using PCIE0 and PCIE1 instances of
> + * PCIe on the J7 common processor board.
> + *
> + * J7 Common Processor Board Product Link: https://www.ti.com/tool/J721EXCPXEVM
> + *
> + * Copyright (C) 2025 Texas Instruments Incorporated - https://www.ti.com/
> + */
> +
> +/dts-v1/;
> +/plugin/;
> +
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/soc/ti,sci_pm_domain.h>
> +
> +#include "k3-pinctrl.h"
> +
> +&{/} {
> +       epf-bus {
> +               compatible = "pci-epf-bus";

There is no such binding upstream nor one pending. This needs to be dropped.

Rob