Re: [PATCH v2] perf stat: Fix non-uniquified hybrid legacy events

From: Namhyung Kim
Date: Tue Mar 04 2025 - 13:48:44 EST


On Wed, 26 Feb 2025 14:55:25 +0000, James Clark wrote:
> Legacy hybrid events have attr.type == PERF_TYPE_HARDWARE, so they look
> like plain legacy events if we only look at attr.type. But legacy events
> should still be uniquified if they were opened on a non-legacy PMU. Fix
> it by checking if the evsel is hybrid and forcing needs_uniquify
> before looking at the attr.type.
>
> This restores PMU names on hybrid systems and also changes "perf stat
> metrics (shadow stat) test" from a FAIL back to a SKIP (on hybrid). The
> test was gated on "cycles" appearing alone which doesn't happen on
> here.
>
> [...]
Applied to perf-tools-next, thanks!

Best regards,
Namhyung