Re: [PATCH 0/3] Add support for hidden choices to platform_profile
From: Rafael J. Wysocki
Date: Tue Mar 04 2025 - 15:00:00 EST
On Tue, Mar 4, 2025 at 5:22 PM Ilpo Järvinen
<ilpo.jarvinen@xxxxxxxxxxxxxxx> wrote:
>
> On Fri, 28 Feb 2025, Mario Limonciello wrote:
>
> > From: Mario Limonciello <mario.limonciello@xxxxxxx>
> >
> > When two drivers provide platform profile handlers but use different
> > strings to mean (essentially) the same thing the legacy interface won't
> > export them because it only shows profiles common to multiple drivers.
> >
> > This causes an unexpected behavior to people who have upgraded from an
> > earlier kernel because if multiple drivers have bound platform profile
> > handlers they might not be able to access profiles they were expecting.
> >
> > Introduce a concept of a "hidden choice" that drivers can register and
> > the platform profile handler code will utilize when using the legacy
> > interface.
> >
> > There have been some other attempts at solving this issue in other ways.
> > This serves as an alternative to those attempts.
> >
> > Link: https://lore.kernel.org/platform-driver-x86/e64b771e-3255-42ad-9257-5b8fc6c24ac9@xxxxxx/T/#t
> > Link: https://lore.kernel.org/platform-driver-x86/CAGwozwF-WVEgiAbWbRCiUaXf=BVa3KqmMJfs06trdMQHpTGmjQ@xxxxxxxxxxxxxx/T/#m2f3929e2d4f73cc0eedd14738170dad45232fd18
> > Cc: Antheas Kapenekakis <lkml@xxxxxxxxxxx>
> > Cc: "Luke D. Jones" <luke@xxxxxxxxxx>
> >
> > Mario Limonciello (3):
> > ACPI: platform_profile: Add support for hidden choices
> > platform/x86/amd: pmf: Add 'quiet' to hidden choices
> > platform/x86/amd: pmf: Add balanced-performance to hidden choices
> >
> > drivers/acpi/platform_profile.c | 94 +++++++++++++++++++++++-------
> > drivers/platform/x86/amd/pmf/sps.c | 11 ++++
> > include/linux/platform_profile.h | 3 +
> > 3 files changed, 87 insertions(+), 21 deletions(-)
> >
> >
>
> Acked-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
All 3 patches applied as 6.14-rc6 material, thanks!