Re: [PATCH v2 1/4] HID: apple: Use common table for MacBook Pro fn mapping

[Jiri Kosina]

On Fri, 14 Feb 2025, Aditya Garg wrote:

> From: Aditya Garg <gargaditya08@xxxxxxxx>
> 
> The only difference between the fn mapping of the MacBook Pros with esc key
> and those without is of the presence of KEY_GRAVE in the translation table.
> 
> We can easily use a flag instead of writing the whole table again to omit
> it from the models that have an esc key.
> 
> Additionally, APPLE_IGNORE_MOUSE quirk was unused in this driver, so has
> been removed in this commit.
> 
> Signed-off-by: Aditya Garg <gargaditya08@xxxxxxxx>
> ---
> drivers/hid/hid-apple.c | 72 ++++++++++++++++-------------------------
> 1 file changed, 27 insertions(+), 45 deletions(-)
> 
> diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
> index 49812a76b..e31c9e8e8 100644
> --- a/drivers/hid/hid-apple.c
> +++ b/drivers/hid/hid-apple.c
> @@ -30,7 +30,7 @@
> #include "hid-ids.h"
> 
> #define APPLE_RDESC_JIS		BIT(0)
> -#define APPLE_IGNORE_MOUSE	BIT(1)
> +/* BIT(1) reserved, was: APPLE_IGNORE_MOUSE */
> #define APPLE_HAS_FN		BIT(2)
> /* BIT(3) reserved, was: APPLE_HIDDEV */
> #define APPLE_ISO_TILDE_QUIRK	BIT(4)
> @@ -43,7 +43,8 @@
> #define APPLE_IS_NON_APPLE	BIT(11)
> #define APPLE_MAGIC_BACKLIGHT	BIT(12)

This patch is corrupt -- the context lines are missing the leading space. 
For some reason, it's only the 1/4 which is corrupted, the rest is fine.

Can you please look into this and resubmit?

Thanks,

-- 
Jiri Kosina
SUSE Labs