Re: [PATCH v7 2/2] cxl/pci: Add trace logging for CXL PCIe Port RAS errors

[Koralahalli Channabasappa, Smita]

Hi Alison,

Thanks for the review.

On 3/4/2025 10:56 AM, Alison Schofield wrote:
> On Wed, Feb 26, 2025 at 10:11:57PM +0000, Smita Koralahalli wrote:
>
> Kind of a nit, but since these are exposed to user space suggest
> matching these names now.
>
> > +++ b/drivers/cxl/core/trace.h
> > @@ -48,6 +48,34 @@
> >   	{ CXL_RAS_UC_IDE_RX_ERR, "IDE Rx Error" }			  \
> >   )
> >   
> > +TRACE_EVENT(cxl_port_aer_uncorrectable_error,
> > +	TP_PROTO(struct device *dev, u32 status, u32 fe, u32 *hl),
> > +	TP_ARGS(dev, status, fe, hl),
> > +	TP_STRUCT__entry(
> > +		__string(devname, dev_name(dev))
> > +		__string(parent, dev_name(dev->parent))
>
> Above devname, parent

Ok I'm planning to keep as device and parent. Let me know if wording 
"host" is preferred over "parent".

Thanks
Smita
> > +		__field(u32, status)
> > +		__field(u32, first_error)
> > +		__array(u32, header_log, CXL_HEADERLOG_SIZE_U32)
> > +	),
> > +	TP_fast_assign(
> > +		__assign_str(devname);
> > +		__assign_str(parent);
> > +		__entry->status = status;
> > +		__entry->first_error = fe;
> > +		/*
> > +		 * Embed the 512B headerlog data for user app retrieval and
> > +		 * parsing, but no need to print this in the trace buffer.
> > +		 */
> > +		memcpy(__entry->header_log, hl, CXL_HEADERLOG_SIZE);
> > +	),
> > +	TP_printk("device=%s host=%s status: '%s' first_error: '%s'",
>
> Above device, host
>
> > +		  __get_str(devname), __get_str(parent),
> > +		  show_uc_errs(__entry->status),
> > +		  show_uc_errs(__entry->first_error)
> > +	)
> > +);
> > +
> >   TRACE_EVENT(cxl_aer_uncorrectable_error,
> >   	TP_PROTO(const struct cxl_memdev *cxlmd, u32 status, u32 fe, u32 *hl),
> >   	TP_ARGS(cxlmd, status, fe, hl),
> > @@ -96,6 +124,25 @@ TRACE_EVENT(cxl_aer_uncorrectable_error,
> >   	{ CXL_RAS_CE_PHYS_LAYER_ERR, "Received Error From Physical Layer" }	\
> >   )
> >   
>
> same thing below -
>
>
> > +TRACE_EVENT(cxl_port_aer_correctable_error,
> > +	TP_PROTO(struct device *dev, u32 status),
> > +	TP_ARGS(dev, status),
> > +	TP_STRUCT__entry(
> > +		__string(devname, dev_name(dev))
> > +		__string(parent, dev_name(dev->parent))
> > +		__field(u32, status)
> > +	),
> > +	TP_fast_assign(
> > +		__assign_str(devname);
> > +		__assign_str(parent);
> > +		__entry->status = status;
> > +	),
> > +	TP_printk("device=%s host=%s status='%s'",
> > +		  __get_str(devname), __get_str(parent),
> > +		  show_ce_errs(__entry->status)
> > +	)
> > +);
> > +
> >   TRACE_EVENT(cxl_aer_correctable_error,
> >   	TP_PROTO(const struct cxl_memdev *cxlmd, u32 status),
> >   	TP_ARGS(cxlmd, status),
> > --
> > 2.17.1