Re: [PATCH] scsi: hisi: remove incorrect ACPI_PTR annotations

From: Yihang Li
Date: Tue Mar 04 2025 - 20:36:49 EST




On 2025/3/4 13:12, Uwe Kleine-König wrote:
> Hello,
>
> On Wed, Feb 26, 2025 at 11:23:18AM +0800, Yihang Li wrote:
>> On 2025/2/26 0:36, Arnd Bergmann wrote:
>>> From: Arnd Bergmann <arnd@xxxxxxxx>
>>>
>>> Building with W=1 shows a warning about sas_v2_acpi_match being unused when
>>> CONFIG_OF is disabled:
>>>
>>> drivers/scsi/hisi_sas/hisi_sas_v2_hw.c:3635:36: error: unused variable 'sas_v2_acpi_match' [-Werror,-Wunused-const-variable]
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>>
>> Looks good. So Reviewed-by: Yihang Li <liyihang9@xxxxxxxxxx>
>
> If you put your Reviewed-by tag in a separate line, the tooling that
> most maintainers use pick it up automatically. Martin applied your patch
> (currently as commit 7a9c0476d4073e742f474e71feeef4f54add4bc9 in
> https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git 6.15/scsi-staging
> ) indeed without your tag.
>

Ok, thanks for the reminder. I'll pay attention next time.

Thanks
Yihang