Re: [PATCH v1 0/4] Input: Increase size of phys in the drivers

From: Dmitry Torokhov
Date: Wed Mar 05 2025 - 02:19:06 EST


Hi Andy,

On Tue, Mar 04, 2025 at 02:14:12PM +0200, Andy Shevchenko wrote:
> On Fri, Feb 28, 2025 at 02:07:43PM +0200, Andy Shevchenko wrote:
> > The drivers are using local member of 32 bytes to hold up to 40 (one-byte)
> > characters. GCC complains on that. This series fixes the issue in the affected
> > input drivers. Note, this is currently the biggest part of the warnings that
> > are being treated as errors with the default configurations on x86. With this
> > being applied we become quite close to enable CONFIG_WERROR=y (which is default
> > and basically reverted) in CIs. Clang, OTOH, has currently no issues with that.
>
> Would be nice to have a comment on this rather sooner as this impacts
> the compilation by `make W=1` with WERROR=y (which is default).

I do not like the change. There are no bugs, only GCC being paranoid.
Are there any other ways to shut it up? In [1] Jeff says that switching
to scnprintf() shuts GCC up...

[1] https://lore.kernel.org/r/Z3rIvp0hzS+yzvJA@nixie71

Thanks.

--
Dmitry