Re: [PATCH net] netpoll: guard __netpoll_send_skb() with RCU read lock

From: Breno Leitao
Date: Wed Mar 05 2025 - 04:10:06 EST


Hello Jakub,

On Tue, Mar 04, 2025 at 05:47:32PM -0800, Jakub Kicinski wrote:
> On Mon, 03 Mar 2025 03:44:12 -0800 Breno Leitao wrote:
> > + guard(rcu)();
>
> Scoped guards if you have to.
> Preferably just lock/unlock like a normal person..

Sure, I thought that we would be moving to scoped guards all across the
board, at least that was my reading for a similar patch I sent a while
ago:

https://lore.kernel.org/all/20250224123016.GA17456@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/

Anyway, in which case should I use scoped guard instead of just being
like a normal person?

Thanks for the review,
--breno