Re: [PATCH v2 1/1] accel/habanalabs: Switch to use %ptTs

From: Andy Shevchenko
Date: Wed Mar 05 2025 - 04:40:25 EST


On Tue, Mar 04, 2025 at 09:01:59PM +0200, Jani Nikula wrote:
> On Thu, 06 Feb 2025, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > Use %ptTs instead of open-coded variant to print contents of time64_t type
> > in human readable form.

...

> > - char pq_time_str[64] = "N/A", eq_time_str[64] = "N/A";
>
> The "N/A" gets replaced with, I presume, "1970-01-01 00:00:00" for 0
> timestamps, which is not the same thing.

It's used only in dev_err() below which is why it's fine to update.
Should I mention this in the commit message?

> But I honestly don't know anything about the driver.

--
With Best Regards,
Andy Shevchenko