Re: [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP

[George Cherian]

From: Marek Behún <kabel@xxxxxxxxxx> 
Sent: Wednesday, March 5, 2025 3:48 PM
To: George Cherian <gcherian@xxxxxxxxxxx>
Cc: linux@xxxxxxxxxxxx; wim@xxxxxxxxxxxxxxxxxx; jwerner@xxxxxxxxxxxx; evanbenn@xxxxxxxxxxxx; krzk@xxxxxxxxxx; mazziesaccount@xxxxxxxxx; thomas.richard@xxxxxxxxxxx; lma@xxxxxxxxxxxx; bleung@xxxxxxxxxxxx; support.opensource@xxxxxxxxxxx; shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; andy@xxxxxxxxxx; paul@xxxxxxxxxxxxxxx; alexander.usyskin@xxxxxxxxx; andreas.werner@xxxxxx; daniel@xxxxxxxxx; romain.perier@xxxxxxxxx; avifishman70@xxxxxxxxx; tmaimon77@xxxxxxxxx; tali.perry1@xxxxxxxxx; venture@xxxxxxxxxx; yuenn@xxxxxxxxxx; benjaminfair@xxxxxxxxxx; maddy@xxxxxxxxxxxxx; mpe@xxxxxxxxxxxxxx; npiggin@xxxxxxxxx; christophe.leroy@xxxxxxxxxx; naveen@xxxxxxxxxx; mwalle@xxxxxxxxxx; xingyu.wu@xxxxxxxxxxxxxxxx; ziv.xu@xxxxxxxxxxxxxxxx; hayashi.kunihiko@xxxxxxxxxxxxx; mhiramat@xxxxxxxxxx; linux-watchdog@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; chrome-platform@xxxxxxxxxxxxxxx; imx@xxxxxxxxxxxxxxx; linux-mips@xxxxxxxxxxxxxxx; openbmc@xxxxxxxxxxxxxxxx; linuxppc-dev@xxxxxxxxxxxxxxxx; patches@xxxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP
> Hi George,
>
> why is armada_37xx_wdt also here?
> The stop function in that driver may not sleep.
Marek,

Thanks for reviewing.
Since the stop function has a regmap_write(), I thought it might sleep.
Now that you pointed it out, I assume that it is an MMIO based regmap being used for armada.
I will update the same in the next version

>
> Marek

-George