Re: [PATCH v2] drm/panthor: Update CS_STATUS_ defines to correct values
From: Steven Price
Date: Wed Mar 05 2025 - 05:43:57 EST
On 03/03/2025 18:04, Ashley Smith wrote:
> Values for SC_STATUS_BLOCKED_REASON_ are documented in the G610 "Odin"
> GPU specification (CS_STATUS_BLOCKED_REASON register).
>
> This change updates the defines to the correct values.
>
> Fixes: 2718d91816ee ("drm/panthor: Add the FW logical block")
> Signed-off-by: Ashley Smith <ashley.smith@xxxxxxxxxxxxx>
Reviewed-by: Steven Price <steven.price@xxxxxxx>
I'll push this to drm-misc-next.
Steve
> ---
> Changes in v2:
> - Rename _RES to _RESOURCE
> ---
> drivers/gpu/drm/panthor/panthor_fw.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_fw.h b/drivers/gpu/drm/panthor/panthor_fw.h
> index 22448abde992..6598d96c6d2a 100644
> --- a/drivers/gpu/drm/panthor/panthor_fw.h
> +++ b/drivers/gpu/drm/panthor/panthor_fw.h
> @@ -102,9 +102,9 @@ struct panthor_fw_cs_output_iface {
> #define CS_STATUS_BLOCKED_REASON_SB_WAIT 1
> #define CS_STATUS_BLOCKED_REASON_PROGRESS_WAIT 2
> #define CS_STATUS_BLOCKED_REASON_SYNC_WAIT 3
> -#define CS_STATUS_BLOCKED_REASON_DEFERRED 5
> -#define CS_STATUS_BLOCKED_REASON_RES 6
> -#define CS_STATUS_BLOCKED_REASON_FLUSH 7
> +#define CS_STATUS_BLOCKED_REASON_DEFERRED 4
> +#define CS_STATUS_BLOCKED_REASON_RESOURCE 5
> +#define CS_STATUS_BLOCKED_REASON_FLUSH 6
> #define CS_STATUS_BLOCKED_REASON_MASK GENMASK(3, 0)
> u32 status_blocked_reason;
> u32 status_wait_sync_value_hi;
>
> base-commit: 16e57a72780931c3c70dbc928aeee4a0518075de