Re: [PATCH v1] serial: qcom-geni: Remove alias dependency from qcom serial driver

[kernel test robot]

Hi Viken,

kernel test robot noticed the following build warnings:

[auto build test WARNING on tty/tty-testing]
[also build test WARNING on tty/tty-next tty/tty-linus usb/usb-testing usb/usb-next usb/usb-linus linus/master v6.14-rc5 next-20250304]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Viken-Dadhaniya/serial-qcom-geni-Remove-alias-dependency-from-qcom-serial-driver/20250304-152222
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
patch link:    https://lore.kernel.org/r/20250304071423.4033565-1-quic_vdadhani%40quicinc.com
patch subject: [PATCH v1] serial: qcom-geni: Remove alias dependency from qcom serial driver
config: x86_64-buildonly-randconfig-006-20250305 (https://download.01.org/0day-ci/archive/20250305/202503051821.tqFJ961p-lkp@xxxxxxxxx/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250305/202503051821.tqFJ961p-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503051821.tqFJ961p-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> drivers/tty/serial/qcom_geni_serial.c:267:40: warning: variable 'port' is uninitialized when used here [-Wuninitialized]
     267 |                         line = idr_alloc(&port_idr, (void *)port, max_alias_num + 1, nr_ports,
         |                                                             ^~~~
   drivers/tty/serial/qcom_geni_serial.c:255:36: note: initialize the variable 'port' to silence this warning
     255 |         struct qcom_geni_serial_port *port;
         |                                           ^
         |                                            = NULL
   1 warning generated.


vim +/port +267 drivers/tty/serial/qcom_geni_serial.c

   252	
   253	static struct qcom_geni_serial_port *get_port_from_line(int line, bool console)
   254	{
   255		struct qcom_geni_serial_port *port;
   256		int nr_ports = console ? GENI_UART_CONS_PORTS : GENI_UART_PORTS;
   257	
   258		if (console) {
   259			if (line < 0 || line >= nr_ports)
   260				return ERR_PTR(-ENXIO);
   261	
   262			port = &qcom_geni_console_port;
   263		} else {
   264			int max_alias_num = of_alias_get_highest_id("serial");
   265	
   266			if (line < 0 || line >= nr_ports)
 > 267				line = idr_alloc(&port_idr, (void *)port, max_alias_num + 1, nr_ports,
   268						 GFP_KERNEL);
   269			else
   270				line = idr_alloc(&port_idr, (void *)port, line, nr_ports, GFP_KERNEL);
   271	
   272			if (line < 0)
   273				return ERR_PTR(-ENXIO);
   274	
   275			port = &qcom_geni_uart_ports[line];
   276		}
   277		return port;
   278	}
   279	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki