Re: [PATCH v5 5/9] gpio: aggregator: add 'name' attribute for custom GPIO line names

[Koichiro Den]

On Thu, Feb 27, 2025 at 10:50:34AM GMT, Bartosz Golaszewski wrote:
> On Mon, Feb 24, 2025 at 3:32 PM Koichiro Den <koichiro.den@xxxxxxxxxxxxx> wrote:
> >
> > Previously, there was no way to assign names to GPIO lines exported
> > through the aggregator when the device was created via sysfs.
> >
> > Allow users to set custom line names via a 'name' attribute and
> > expose them using swnode.
> >
> > Signed-off-by: Koichiro Den <koichiro.den@xxxxxxxxxxxxx>
> > ---
> 
> IMO this should be part of the previous commit, there's no reason to
> split the configfs implementation. But only change that if there'll be
> a v6, otherwise I'll take it as is.

Honestly, I held off replying here, hoping to get some input on:
https://lore.kernel.org/all/CAMRc=MegKxwX-RjQQcWMGe_JQyRCv82WRRbD0naYkeXshTGXGQ@xxxxxxxxxxxxxx/
since I thought the decision on sending v6 might depend on the feedback.
Anyhow, thank you for reviewing.

Koichiro

> 
> Bart