Re: [PATCH 01/22] rust: init: disable doctests

[Benno Lossin]

On Wed Mar 5, 2025 at 3:09 PM CET, Andreas Hindborg wrote:
> "Benno Lossin" <benno.lossin@xxxxxxxxx> writes:
>
>> On Wed Mar 5, 2025 at 9:51 AM CET, Andreas Hindborg wrote:
>>> "Benno Lossin" <benno.lossin@xxxxxxxxx> writes:
>>>
>>>> This is the first commit in a series that splits off the pin-init crate
>>>> from the kernel crate.
>>>
>>> I recently learned that using imperative mode in the commit message is
>>> preferred [1]. You might want to consider that for next spin.
>>
>> Thanks for pointing that out, any suggestions for this concrete case? I
>> wasn't able to come up with an imperative statement.
>
> I would drop the first paragraph entirely, since the subject is 01/22
> and the cover letter provides plenty of context.

Done.

>   The build system cannot handle doctests in the kernel crate in files
>   outside of `rust/kernel/`. Subsequent commits will move files out
>   of that directory, but will still compile them as part of the kernel
>   crate. Thus, ignore all doctests in the to-be-moved files.
>
>   Leave tests disabled until they are separated into their
>   own crate and they stop causing breakage.
>
> Not sure if it is better? More robot for sure 🤖

Thanks!

>
> This part from the original is not correct:?
>
>   since then the doctests of that new crate will be handled as normal
>   host doctests.
>
> The build system will not run those tests when they are not in the
> kernel crate?

Yes, that sentence was from an old version when I tried to get them to
work. Removed it in next version.

---
Cheers,
Benno