Re: [PATCH] inotify: disallow watches on unsupported filesystems
From: kernel test robot
Date: Wed Mar 05 2025 - 10:09:05 EST
Hi Seyediman,
kernel test robot noticed the following build errors:
[auto build test ERROR on jack-fs/fsnotify]
[also build test ERROR on linus/master v6.14-rc5 next-20250305]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Seyediman-Seyedarab/inotify-disallow-watches-on-unsupported-filesystems/20250304-160213
base: https://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git fsnotify
patch link: https://lore.kernel.org/r/20250304080044.7623-1-ImanDevel%40gmail.com
patch subject: [PATCH] inotify: disallow watches on unsupported filesystems
config: powerpc-randconfig-001-20250305 (https://download.01.org/0day-ci/archive/20250305/202503052203.vK0McbRm-lkp@xxxxxxxxx/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250305/202503052203.vK0McbRm-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503052203.vK0McbRm-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
>> fs/notify/inotify/inotify_user.c:702:33: error: use of undeclared identifier 'unwatchable_fs'; did you mean 'is_unwatchable_fs'?
702 | for (int i = 0; i < ARRAY_SIZE(unwatchable_fs); i++)
| ^~~~~~~~~~~~~~
| is_unwatchable_fs
include/linux/array_size.h:11:33: note: expanded from macro 'ARRAY_SIZE'
11 | #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
| ^
fs/notify/inotify/inotify_user.c:700:20: note: 'is_unwatchable_fs' declared here
700 | static inline bool is_unwatchable_fs(struct inode *inode)
| ^
>> fs/notify/inotify/inotify_user.c:702:33: error: use of undeclared identifier 'unwatchable_fs'; did you mean 'is_unwatchable_fs'?
702 | for (int i = 0; i < ARRAY_SIZE(unwatchable_fs); i++)
| ^~~~~~~~~~~~~~
| is_unwatchable_fs
include/linux/array_size.h:11:48: note: expanded from macro 'ARRAY_SIZE'
11 | #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
| ^
fs/notify/inotify/inotify_user.c:700:20: note: 'is_unwatchable_fs' declared here
700 | static inline bool is_unwatchable_fs(struct inode *inode)
| ^
>> fs/notify/inotify/inotify_user.c:702:22: error: subscript of pointer to function type 'bool (struct inode *)' (aka '_Bool (struct inode *)')
702 | for (int i = 0; i < ARRAY_SIZE(unwatchable_fs); i++)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/array_size.h:11:47: note: expanded from macro 'ARRAY_SIZE'
11 | #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
| ^~~~~
>> fs/notify/inotify/inotify_user.c:702:33: error: use of undeclared identifier 'unwatchable_fs'; did you mean 'is_unwatchable_fs'?
702 | for (int i = 0; i < ARRAY_SIZE(unwatchable_fs); i++)
| ^~~~~~~~~~~~~~
| is_unwatchable_fs
include/linux/array_size.h:11:75: note: expanded from macro 'ARRAY_SIZE'
11 | #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
| ^
include/linux/compiler.h:249:65: note: expanded from macro '__must_be_array'
249 | #define __must_be_array(a) __BUILD_BUG_ON_ZERO_MSG(__same_type((a), &(a)[0]), "must be array")
| ^
include/linux/compiler_types.h:483:63: note: expanded from macro '__same_type'
483 | #define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof(b))
| ^
include/linux/compiler.h:245:79: note: expanded from macro '__BUILD_BUG_ON_ZERO_MSG'
245 | #define __BUILD_BUG_ON_ZERO_MSG(e, msg) ((int)sizeof(struct {_Static_assert(!(e), msg);}))
| ^
fs/notify/inotify/inotify_user.c:700:20: note: 'is_unwatchable_fs' declared here
700 | static inline bool is_unwatchable_fs(struct inode *inode)
| ^
>> fs/notify/inotify/inotify_user.c:702:33: error: use of undeclared identifier 'unwatchable_fs'; did you mean 'is_unwatchable_fs'?
702 | for (int i = 0; i < ARRAY_SIZE(unwatchable_fs); i++)
| ^~~~~~~~~~~~~~
| is_unwatchable_fs
include/linux/array_size.h:11:75: note: expanded from macro 'ARRAY_SIZE'
11 | #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
| ^
include/linux/compiler.h:249:71: note: expanded from macro '__must_be_array'
249 | #define __must_be_array(a) __BUILD_BUG_ON_ZERO_MSG(__same_type((a), &(a)[0]), "must be array")
| ^
include/linux/compiler_types.h:483:74: note: expanded from macro '__same_type'
483 | #define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof(b))
| ^
include/linux/compiler.h:245:79: note: expanded from macro '__BUILD_BUG_ON_ZERO_MSG'
245 | #define __BUILD_BUG_ON_ZERO_MSG(e, msg) ((int)sizeof(struct {_Static_assert(!(e), msg);}))
| ^
fs/notify/inotify/inotify_user.c:700:20: note: 'is_unwatchable_fs' declared here
700 | static inline bool is_unwatchable_fs(struct inode *inode)
| ^
>> fs/notify/inotify/inotify_user.c:702:22: error: subscript of pointer to function type 'bool (struct inode *)' (aka '_Bool (struct inode *)')
702 | for (int i = 0; i < ARRAY_SIZE(unwatchable_fs); i++)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/array_size.h:11:59: note: expanded from macro 'ARRAY_SIZE'
11 | #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler.h:249:70: note: expanded from macro '__must_be_array'
249 | #define __must_be_array(a) __BUILD_BUG_ON_ZERO_MSG(__same_type((a), &(a)[0]), "must be array")
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:483:74: note: expanded from macro '__same_type'
483 | #define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof(b))
| ^
include/linux/compiler.h:245:79: note: expanded from macro '__BUILD_BUG_ON_ZERO_MSG'
245 | #define __BUILD_BUG_ON_ZERO_MSG(e, msg) ((int)sizeof(struct {_Static_assert(!(e), msg);}))
| ^
fs/notify/inotify/inotify_user.c:703:31: error: use of undeclared identifier 'unwatchable_fs'; did you mean 'is_unwatchable_fs'?
703 | if (inode->i_sb->s_magic == unwatchable_fs[i])
| ^~~~~~~~~~~~~~
| is_unwatchable_fs
fs/notify/inotify/inotify_user.c:700:20: note: 'is_unwatchable_fs' declared here
700 | static inline bool is_unwatchable_fs(struct inode *inode)
| ^
fs/notify/inotify/inotify_user.c:703:31: error: subscript of pointer to function type 'bool (struct inode *)' (aka '_Bool (struct inode *)')
703 | if (inode->i_sb->s_magic == unwatchable_fs[i])
| ^~~~~~~~~~~~~~
8 errors generated.
vim +702 fs/notify/inotify/inotify_user.c
698
699
700 static inline bool is_unwatchable_fs(struct inode *inode)
701 {
> 702 for (int i = 0; i < ARRAY_SIZE(unwatchable_fs); i++)
703 if (inode->i_sb->s_magic == unwatchable_fs[i])
704 return true;
705 return false;
706 }
707
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki