Re: [PATCH v4 2/8] dt-bindings: dsp: fsl,dsp: Add resets property

From: Rob Herring (Arm)
Date: Wed Mar 05 2025 - 12:05:24 EST



On Wed, 05 Mar 2025 12:00:30 +0200, Daniel Baluta wrote:
> Assert and deassert functionality of the DSP found on i.MX8MP is
> realized by combining control bits from two modules: Audio Block
> Control and Debug Access Port.
>
> Audio block control bits are used to Run/Stall the DSP core
> while the DAP bits are used for software reset the core.
>
> The original plan was to use fsl,dsp-ctrl property and to refer the
> audiomix bits via syscon interface. This proposal received NACK from
> community we shouldn't abuse the syscon interface [1].
>
> So remove fsl,dsp-ctrl property for i.MX8MP and use reset control
> interface instead.
>
> Example dts node only uses runstall control now, but softreset will
> be added in the future when we will convert the softreset functionality
> to use reset controller API.
>
> [1] https://patchwork.kernel.org/project/imx/patch/20250212085222.107102-6-daniel.baluta@xxxxxxx/
>
> Reviewed-by: Frank Li <Frank.Li@xxxxxxx>
> Signed-off-by: Daniel Baluta <daniel.baluta@xxxxxxx>
> ---
> .../devicetree/bindings/dsp/fsl,dsp.yaml | 24 ++++++++++++++++++-
> 1 file changed, 23 insertions(+), 1 deletion(-)
>

Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>