Re: [PATCH] include/linux/pipe_fs_i: Add htmldoc annotation for "head_tail" member
From: Linus Torvalds
Date: Wed Mar 05 2025 - 12:35:46 EST
On Wed, 5 Mar 2025 at 01:24, K Prateek Nayak <kprateek.nayak@xxxxxxx> wrote:
>
> Add htmldoc annotation for the newly introduced "head_tail" member
> describing it to be a union of the pipe_inode_info's @head and @tail
> members.
Applied.
I also committed the pipe_occupancy() fix for 32-bit, but did so
without testing - it was ObviouslyCorrect(tm), but considering that
everybody missed it in the original patch, "obvious" is all relative.
And it turns out my worry about pipe_discard_from() was unnecessary.
Yes, the code is buggy. But no, it doesn't matter. Why? There are no
callers of that function ;)
That said, I still hope people will take a look at the code and see if
there's anything else I missed.
Oh, and testing. Testing would be good.
Linus