Re: [PATCH 1/2] clk: samsung: Add missing mod_devicetable.h header

From: Krzysztof Kozlowski
Date: Wed Mar 05 2025 - 14:55:24 EST


On 05/03/2025 15:23, Tudor Ambarus wrote:
>
>
> On 3/4/25 6:45 PM, Krzysztof Kozlowski wrote:
>> drivers/clk/samsung/clk-exynos-audss.c | 1 +
>> drivers/clk/samsung/clk-exynos-clkout.c | 1 +
>
> drivers/clk/samsung/clk-exynos2200.c can benefit of the inclusion too.

Yes, this was reported by Stephen and I was waiting for reply from the
author.

>
>> drivers/clk/samsung/clk-exynos3250.c | 2 +-
>
> drivers/clk/samsung/clk-exynos4.c too

I missed it, weird. Thanks.

>
>> drivers/clk/samsung/clk-exynos4412-isp.c | 1 +
>
> drivers/clk/samsung/clk-exynos5-subcmu.c too

How did I search for of_device_id...

>
>> drivers/clk/samsung/clk-exynos5250.c | 1 +
>> drivers/clk/samsung/clk-exynos5420.c | 1 +
>> drivers/clk/samsung/clk-exynos5433.c | 1 +
>
> drivers/clk/samsung/clk-exynos7870.c too

Same as Exynos2200. I guess I will fix it, instead of authors.

>
>> drivers/clk/samsung/clk-exynos7885.c | 1 +
>> drivers/clk/samsung/clk-exynos850.c | 1 +
>> drivers/clk/samsung/clk-exynos8895.c | 1 +
>> drivers/clk/samsung/clk-exynos990.c | 1 +
>> drivers/clk/samsung/clk-exynosautov9.c | 1 +
>> drivers/clk/samsung/clk-exynosautov920.c | 1 +
>> drivers/clk/samsung/clk-fsd.c | 1 +
>> drivers/clk/samsung/clk-gs101.c | 1 +
>> drivers/clk/samsung/clk-s5pv210-audss.c | 1 +
>
> drivers/clk/samsung/clk.c and drivers/clk/samsung/clk.h too.

Indeed.

>
> With that:
> Reviewed-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx>

Thanks

Best regards,
Krzysztof