Re: [PATCH v3 2/6] phy: qualcomm: qcom-uniphy-pcie 28LP add support for IPQ5018

From: Dmitry Baryshkov
Date: Wed Mar 05 2025 - 15:39:37 EST


On Wed, Mar 05, 2025 at 05:41:27PM +0400, George Moussalem wrote:
> From: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx>
>
> From: Nitheesh Sekar <quic_nsekar@xxxxxxxxxxx>

Something is wrong here. There can't be two authors for the patch.

LGTM otherwise

>
> The Qualcomm UNIPHY PCIe PHY 28LP is found on both IPQ5332 and IPQ5018.
> Adding the PHY init sequence, pipe clock rate, and compatible for IPQ5018.
>
> Signed-off-by: Nitheesh Sekar <quic_nsekar@xxxxxxxxxxx>
> Signed-off-by: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx>
> Signed-off-by: George Moussalem <george.moussalem@xxxxxxxxxxx>
> ---
> .../phy/qualcomm/phy-qcom-uniphy-pcie-28lp.c | 45 +++++++++++++++++++
> 1 file changed, 45 insertions(+)
>

--
With best wishes
Dmitry