Re: [PATCH 2/4] pinctrl: renesas: rzg2l: Fix missing of_node_put() call

[Lad, Prabhakar]

On Wed, Mar 5, 2025 at 4:39 PM Fabrizio Castro
<fabrizio.castro.jz@xxxxxxxxxxx> wrote:
>
> of_parse_phandle_with_fixed_args() requires its caller to
> call into of_node_put() on the node pointer from the output
> structure, but such a call is currently missing.
>
> Call into of_node_put() to rectify that.
>
> Fixes: c4c4637eb57f ("pinctrl: renesas: Add RZ/G2L pin and gpio controller driver")
> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx>
> ---
>  drivers/pinctrl/renesas/pinctrl-rzg2l.c | 2 ++
>  1 file changed, 2 insertions(+)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>

Cheers,
Prabhakar

> diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> index 9280bc37a623..c72e250f4a15 100644
> --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> @@ -2763,6 +2763,8 @@ static int rzg2l_gpio_register(struct rzg2l_pinctrl *pctrl)
>         if (ret)
>                 return dev_err_probe(pctrl->dev, ret, "Unable to parse gpio-ranges\n");
>
> +       of_node_put(of_args.np);
> +
>         if (of_args.args[0] != 0 || of_args.args[1] != 0 ||
>             of_args.args[2] != pctrl->data->n_port_pins)
>                 return dev_err_probe(pctrl->dev, -EINVAL,
> --
> 2.34.1
>
>