Re: [PATCH 0/3] platform/x86: dell-ddv: Rework battery temperature handling

[Sebastian Reichel]

Hi,

On Wed, Mar 05, 2025 at 06:30:06AM +0100, Armin Wolf wrote:
> This patch series reworks the handling of the battery temperature
> inside the dell-wmi-ddv driver.
> 
> The first patch fixes an issue inside the calculation formula for
> the temperature value that resulted in strange temperature values
> like 29.1 degrees celcius.
> 
> The second patch then simplifies the battery hook handling by using
> devm_battery_hook_register().
> 
> The third patch finally makes use of the new power supply extension
> mechanism to expose the battery temperature to userspace. The
> power supply extension mechanism also takes care that the temperature
> shows up inside the hwmon interface of the associated battery.
> 
> All patches where tested on a Dell Inspiron 3505 and appear to work.

LGTM.

Reviewed-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>

-- Sebastian

> Armin Wolf (3):
>   platform/x86: dell-ddv: Fix temperature calculation
>   platform/x86: dell-ddv: Use devm_battery_hook_register
>   platform/x86: dell-ddv: Use the power supply extension mechanism
> 
>  drivers/platform/x86/dell/dell-wmi-ddv.c | 84 +++++++++++++-----------
>  1 file changed, 46 insertions(+), 38 deletions(-)
> 
> --
> 2.39.5
> 
>

Attachment: signature.asc
Description: PGP signature