Re: [PATCH] EDAC: fix dev_set_name() format string
From: Borislav Petkov
Date: Wed Mar 05 2025 - 17:52:10 EST
On Tue, Mar 04, 2025 at 03:35:58PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> Passing a variable string as the format to dev_set_name() causes a W=1 warning:
>
> drivers/edac/edac_device.c:736:9: error: format not a string literal and no format arguments [-Werror=format-security]
> 736 | ret = dev_set_name(&ctx->dev, name);
> | ^~~
>
> Use a literal "%s" instead so the name can be the argument.
>
> Fixes: db99ea5f2c03 ("EDAC: Add support for EDAC device features control")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> drivers/edac/edac_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette