Re: [PATCH v2] blk-throttle: fix lower bps rate by throtl_trim_slice()

From: Jens Axboe
Date: Wed Mar 05 2025 - 18:25:23 EST



On Thu, 27 Feb 2025 20:06:45 +0800, Yu Kuai wrote:
> The bio submission time may be a few jiffies more than the expected
> waiting time, due to 'extra_bytes' can't be divided in
> tg_within_bps_limit(), and also due to timer wakeup delay.
> In this case, adjust slice_start to jiffies will discard the extra wait time,
> causing lower rate than expected.
>
> Current in-tree code already covers deviation by rounddown(), but turns
> out it is not enough, because jiffies - slice_start can be a multiple of
> throtl_slice.
>
> [...]

Applied, thanks!

[1/1] blk-throttle: fix lower bps rate by throtl_trim_slice()
commit: 29cb955934302a5da525db6b327c795572538426

Best regards,
--
Jens Axboe