RE: [PATCH v2 0/2] phy: freescale: imx8m-pcie: fix and cleanup phy

From: Hongxing Zhu
Date: Wed Mar 05 2025 - 19:24:56 EST


Hi Stefan:
Thanks for the clean up and bug fix. Please update the commit with Frank's comments.
For this series, Acked-by: Richard Zhu <hongxing.zhu@xxxxxxx>

Best Regards
Richard Zhu

> -----Original Message-----
> From: Stefan Eichenberger <eichest@xxxxxxxxx>
> Sent: 2025年3月5日 22:43
> To: vkoul@xxxxxxxxxx; kishon@xxxxxxxxxx; shawnguo@xxxxxxxxxx;
> s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx;
> p.zabel@xxxxxxxxxxxxxx; tharvey@xxxxxxxxxxxxx; Hongxing Zhu
> <hongxing.zhu@xxxxxxx>; Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>
> Cc: linux-phy@xxxxxxxxxxxxxxxxxxx; imx@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH v2 0/2] phy: freescale: imx8m-pcie: fix and cleanup phy
>
> The imx8m-pcie PHY PLL fails to lock under certain conditions when returning
> from suspend. This is resolved by asserting the PHY reset when powering off the
> PHY during suspend. This ensures that the PHY is properly reset when powering
> on again in resume.
>
> Changes in v2:
> - Remove unnecessary check if perst is not null (Philipp)
>
> Stefan Eichenberger (2):
> phy: freescale: imx8m-pcie: cleanup reset logic
> phy: freescale: imx8m-pcie: assert phy reset and perst in power off
>
> drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 23 +++++++++++++---------
> 1 file changed, 14 insertions(+), 9 deletions(-)
>
> --
> 2.45.2