Re: [PATCH v5 08/16] drm/bridge: Add helper to reset bridge pipeline

[Herve Codina]

Hi Maxime,

On Tue, 04 Mar 2025 12:10:51 +0100
Maxime Ripard <mripard@xxxxxxxxxx> wrote:

> Let's provide an helper to make it easier for bridge drivers to
> power-cycle their bridge.
> 
> In order to avoid a circular dependency between that new helper and
> drm_atomic_helper_reset_crtc(), this new helper will be in a
> drm_bridge_helper.c file to follow the pattern we have for other
> objects.
> 
> Co-developed-by: Simona Vetter <simona.vetter@xxxxxxxx>
> Signed-off-by: Maxime Ripard <mripard@xxxxxxxxxx>
> ---
>  drivers/gpu/drm/Makefile            |  1 +
>  drivers/gpu/drm/drm_bridge_helper.c | 55 +++++++++++++++++++++++++++++++++++++
>  include/drm/drm_bridge_helper.h     | 12 ++++++++
>  3 files changed, 68 insertions(+)
> 

Reviewed-by: Herve Codina <herve.codina@xxxxxxxxxxx>

Also tested on my system using the ti-sn65dsi83 driver (updated in this series)
with faults manually generated on the hardware. No regressions were observed in
the driver recovery process. Works fine.

Tested-by: Herve Codina <herve.codina@xxxxxxxxxxx>

Best regards,
Hervé