Re: [PATCH net-next v9 5/6] net: stmmac: configure SerDes according to the interface mode

[Choong Yong Liang]

On 6/3/2025 3:15 pm, Andy Shevchenko wrote:
> Thu, Feb 27, 2025 at 08:15:21PM +0800, Choong Yong Liang kirjoitti:
> > Intel platform will configure the SerDes through PMC API based on the
> > provided interface mode.
> > This patch adds several new functions below:-
> > - intel_tsn_lane_is_available(): This new function reads FIA lane
> >    ownership registers and common lane registers through IPC commands
> >    to know which lane the mGbE port is assigned to.
> > - intel_mac_finish(): To configure the SerDes based on the assigned
> >    lane and latest interface mode, it sends IPC command to the PMC through
> >    PMC driver/API. The PMC acts as a proxy for R/W on behalf of the driver.
> > - intel_set_reg_access(): Set the register access to the available TSN
> >    interface.
> ...
>
> > config DWMAC_INTEL
> >   	default X86
> >   	depends on X86 && STMMAC_ETH && PCI
> >   	depends on COMMON_CLK
> > +	depends on ACPI
> Stray and unexplained change. Please, fix it. We don't need the dependencies
> which are not realised in the compile time.
>
> -- With Best Regards, Andy Shevchenko

Hi Andy,

The dependency on ACPI is necessary because the intel_pmc_ipc.h header 
relies on ACPI functionality to interact with the Intel PMC.