Re: [PATCH] drm/gma500: Replace deprecated strncpy() with strscpy()

[Patrik Jakobsson]

On Tue, Feb 25, 2025 at 9:39 PM Thorsten Blum <thorsten.blum@xxxxxxxxx> wrote:
>
> strncpy() is deprecated for NUL-terminated destination buffers. Use
> strscpy() instead and remove the manual NUL-termination.
>
> Compile-tested only.
>
> Link: https://github.com/KSPP/linux/issues/90
> Cc: linux-hardening@xxxxxxxxxxxxxxx
> Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>

Thanks for the patch.
Applied to drm-misc-next

-Patrik

> ---
>  drivers/gpu/drm/gma500/cdv_intel_dp.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c b/drivers/gpu/drm/gma500/cdv_intel_dp.c
> index cc2ed9b3fd2d..ca7f59ff1fda 100644
> --- a/drivers/gpu/drm/gma500/cdv_intel_dp.c
> +++ b/drivers/gpu/drm/gma500/cdv_intel_dp.c
> @@ -855,8 +855,7 @@ cdv_intel_dp_i2c_init(struct gma_connector *connector,
>
>         memset(&intel_dp->adapter, '\0', sizeof (intel_dp->adapter));
>         intel_dp->adapter.owner = THIS_MODULE;
> -       strncpy (intel_dp->adapter.name, name, sizeof(intel_dp->adapter.name) - 1);
> -       intel_dp->adapter.name[sizeof(intel_dp->adapter.name) - 1] = '\0';
> +       strscpy(intel_dp->adapter.name, name);
>         intel_dp->adapter.algo_data = &intel_dp->algo;
>         intel_dp->adapter.dev.parent = connector->base.kdev;
>
> --
> 2.48.1
>