[PATCH next] initramfs_test: Fix NULL vs IS_ERR() bug in initramfs_test_data()

From: Dan Carpenter
Date: Thu Mar 06 2025 - 04:51:03 EST


The filp_open() function returns error pointers. It never returns
NULL pointers. Update the check to match.

Fixes: b6736cfccb58 ("initramfs_test: kunit tests for initramfs unpacking")
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
---
init/initramfs_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/init/initramfs_test.c b/init/initramfs_test.c
index 6231fe012583..7d14f70beabc 100644
--- a/init/initramfs_test.c
+++ b/init/initramfs_test.c
@@ -222,7 +222,7 @@ static void __init initramfs_test_data(struct kunit *test)
KUNIT_EXPECT_NULL(test, err);

file = filp_open(c[0].fname, O_RDONLY, 0);
- if (!file) {
+ if (IS_ERR(file)) {
KUNIT_FAIL(test, "open failed");
goto out;
}
--
2.47.2