Re: [PATCH 3/8] ftrace: Move trace sysctls into trace.c

[Joel Granados]

On Mon, Mar 03, 2025 at 08:44:55PM -0500, Steven Rostedt wrote:
> On Tue, 18 Feb 2025 10:56:19 +0100
> Joel Granados <joel.granados@xxxxxxxxxx> wrote:
> 
> Nit, change the subject to:
> 
>   tracing: Move trace sysctls into trace.c
Done. Thx for the feedback 

Best
> 
> as I try to only have the "ftrace:" label for modifications that affect
> attaching to functions, and "tracing:" for everything else.
> 
> Acked-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>
> 
> -- Steve
> 
> 
> > Move trace ctl tables into their own const array in
> > kernel/trace/trace.c. The sysctl table register is called with
> > subsys_initcall placing if after its original place in proc_root_init.
> > This is part of a greater effort to move ctl tables into their
> > respective subsystems which will reduce the merge conflicts in
> > kerenel/sysctl.c.
> > 
> > Signed-off-by: Joel Granados <joel.granados@xxxxxxxxxx>
> > ---
...
> > +	},
> > +};
> > +
> > +static int __init init_trace_sysctls(void)
> > +{
> > +	register_sysctl_init("kernel", trace_sysctl_table);
> > +	return 0;
> > +}
> > +subsys_initcall(init_trace_sysctls);
> >  
> >  #ifdef CONFIG_TRACE_EVAL_MAP_FILE
> >  /* Map of enums to their values, for "eval_map" file */
> > 
> 

-- 

Joel Granados