[PATCH 2/2] PM: s2idle: Avoid holding the s2idle_lock when calling pm_wakeup_pending()

From: Ulf Hansson
Date: Thu Mar 06 2025 - 06:43:31 EST


There's no reason to hold the s2idle_lock longer than necessary. Let's
instead acquire it when really needed in s2idle_enter().

Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
---
kernel/power/suspend.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c
index e7aca4e40561..ca09f26cbf4e 100644
--- a/kernel/power/suspend.c
+++ b/kernel/power/suspend.c
@@ -91,10 +91,10 @@ static void s2idle_enter(void)
{
trace_suspend_resume(TPS("machine_suspend"), PM_SUSPEND_TO_IDLE, true);

- raw_spin_lock_irq(&s2idle_lock);
if (pm_wakeup_pending())
goto out;

+ raw_spin_lock_irq(&s2idle_lock);
s2idle_state = S2IDLE_STATE_ENTER;
raw_spin_unlock_irq(&s2idle_lock);

@@ -111,11 +111,10 @@ static void s2idle_enter(void)
wake_up_all_idle_cpus();

raw_spin_lock_irq(&s2idle_lock);
-
- out:
s2idle_state = S2IDLE_STATE_NONE;
raw_spin_unlock_irq(&s2idle_lock);

+ out:
trace_suspend_resume(TPS("machine_suspend"), PM_SUSPEND_TO_IDLE, false);
}

--
2.43.0