Re: [PATCH net-next v3 02/14] motorcomm:yt6801: Add support for a pci table in this module

[Philipp Stanner]

On Fri, 2025-02-28 at 18:00 +0800, Frank Sae wrote:
> Add support for a pci table in this module, and implement pci_driver
>  function to initialize this driver, remove this driver or shutdown
> this
>  driver.
> Implement the fxgmac_drv_probe function to init interrupts, register
> mdio
>  and netdev.
> 
> Signed-off-by: Frank Sae <Frank.Sae@xxxxxxxxxxxxxx>
> ---
>  .../ethernet/motorcomm/yt6801/yt6801_net.c    | 111
> ++++++++++++++++++
>  .../ethernet/motorcomm/yt6801/yt6801_pci.c    | 104 ++++++++++++++++
>  2 files changed, 215 insertions(+)
>  create mode 100644
> drivers/net/ethernet/motorcomm/yt6801/yt6801_pci.c
> 
> diff --git a/drivers/net/ethernet/motorcomm/yt6801/yt6801_net.c
> b/drivers/net/ethernet/motorcomm/yt6801/yt6801_net.c
> index 7cf4d1581..c54550cd4 100644
> --- a/drivers/net/ethernet/motorcomm/yt6801/yt6801_net.c
> +++ b/drivers/net/ethernet/motorcomm/yt6801/yt6801_net.c
> @@ -97,3 +97,114 @@ static int fxgmac_mdio_register(struct
> fxgmac_pdata *priv)
>  	priv->phydev = phydev;
>  	return 0;
>  }
> +
> +static void fxgmac_phy_release(struct fxgmac_pdata *priv)
> +{
> +	FXGMAC_IO_WR_BITS(priv, EPHY_CTRL, RESET, 1);
> +	fsleep(100);
> +}
> +
> +void fxgmac_phy_reset(struct fxgmac_pdata *priv)
> +{
> +	FXGMAC_IO_WR_BITS(priv, EPHY_CTRL, RESET, 0);
> +	fsleep(1500);
> +}
> +
> +#ifdef CONFIG_PCI_MSI
> +static void fxgmac_init_interrupt_scheme(struct fxgmac_pdata *priv)
> +{
> +	struct pci_dev *pdev = to_pci_dev(priv->dev);
> +	int req_vectors = FXGMAC_MAX_DMA_CHANNELS;
> +
> +	/* Since we have FXGMAC_MAX_DMA_CHANNELS channels, we must
> +	 *  ensure the number of cpu core is ok. otherwise, just
> roll back to legacy.
> +	 */
> +	if (num_online_cpus() < FXGMAC_MAX_DMA_CHANNELS - 1)
> +		goto enable_msi_interrupt;
> +
> +	priv->msix_entries =
> +		kcalloc(req_vectors, sizeof(struct msix_entry),
> GFP_KERNEL);
> +	if (!priv->msix_entries)
> +		goto enable_msi_interrupt;
> +
> +	for (u32 i = 0; i < req_vectors; i++)
> +		priv->msix_entries[i].entry = i;
> +
> +	if (pci_enable_msix_exact(pdev, priv->msix_entries,
> req_vectors) < 0) {
> +		/* Roll back to msi */
> +		kfree(priv->msix_entries);
> +		priv->msix_entries = NULL;
> +		yt_err(priv, "enable MSIx err, clear msix
> entries.\n");
> +		goto enable_msi_interrupt;
> +	}
> +
> +	FXGMAC_SET_BITS(priv->int_flag, INT_FLAG, INTERRUPT,
> BIT(INT_FLAG_MSIX_POS));
> +	priv->per_channel_irq = 1;
> +	return;
> +
> +enable_msi_interrupt:
> +	if (pci_enable_msi(pdev) < 0) {
> +		FXGMAC_SET_BITS(priv->int_flag, INT_FLAG, INTERRUPT,
> BIT(INT_FLAG_LEGACY_POS));
> +		yt_err(priv, "MSI err, rollback to LEGACY.\n");
> +	} else {
> +		FXGMAC_SET_BITS(priv->int_flag, INT_FLAG, INTERRUPT,
> BIT(INT_FLAG_MSI_POS));
> +		priv->dev_irq = pdev->irq;
> +	}
> +}
> +#endif
> +
> +int fxgmac_drv_probe(struct device *dev, struct fxgmac_resources
> *res)
> +{
> +	struct fxgmac_pdata *priv;
> +	struct net_device *netdev;
> +	int ret;
> +
> +	netdev = alloc_etherdev_mq(sizeof(struct fxgmac_pdata),
> +				   FXGMAC_MAX_DMA_RX_CHANNELS);
> +	if (!netdev)
> +		return -ENOMEM;
> +
> +	SET_NETDEV_DEV(netdev, dev);
> +	priv = netdev_priv(netdev);
> +
> +	priv->dev = dev;
> +	priv->netdev = netdev;
> +	priv->dev_irq = res->irq;
> +	priv->hw_addr = res->addr;
> +	priv->msg_enable = NETIF_MSG_DRV;
> +	priv->dev_state = FXGMAC_DEV_PROBE;
> +
> +	/* Default to legacy interrupt */
> +	FXGMAC_SET_BITS(priv->int_flag, INT_FLAG, INTERRUPT,
> BIT(INT_FLAG_LEGACY_POS));
> +	pci_set_drvdata(to_pci_dev(priv->dev), priv);
> +
> +	if (IS_ENABLED(CONFIG_PCI_MSI))
> +		fxgmac_init_interrupt_scheme(priv);
> +
> +	ret = fxgmac_init(priv, true);
> +	if (ret < 0) {
> +		yt_err(priv, "fxgmac_init err:%d\n", ret);
> +		goto err_free_netdev;
> +	}
> +
> +	fxgmac_phy_reset(priv);
> +	fxgmac_phy_release(priv);
> +	ret = fxgmac_mdio_register(priv);
> +	if (ret < 0) {
> +		yt_err(priv, "fxgmac_mdio_register err:%d\n", ret);
> +		goto err_free_netdev;
> +	}
> +
> +	netif_carrier_off(netdev);
> +	ret = register_netdev(netdev);
> +	if (ret) {
> +		yt_err(priv, "register_netdev err:%d\n", ret);
> +		goto err_free_netdev;
> +	}
> +
> +	return 0;
> +
> +err_free_netdev:
> +	free_netdev(netdev);
> +	return ret;
> +}
> diff --git a/drivers/net/ethernet/motorcomm/yt6801/yt6801_pci.c
> b/drivers/net/ethernet/motorcomm/yt6801/yt6801_pci.c
> new file mode 100644
> index 000000000..1b80ae15a
> --- /dev/null
> +++ b/drivers/net/ethernet/motorcomm/yt6801/yt6801_pci.c
> @@ -0,0 +1,104 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/* Copyright (c) 2022 - 2024 Motorcomm Electronic Technology
> Co.,Ltd.
> + *
> + * Below is a simplified block diagram of YT6801 chip and its
> relevant
> + * interfaces.
> + *                      ||
> + *  ********************++**********************
> + *  *            | PCIE Endpoint |             *
> + *  *            +---------------+             *
> + *  *                | GMAC |                  *
> + *  *                +--++--+                  *
> + *  *                  |**|                    *
> + *  *         GMII --> |**| <-- MDIO           *
> + *  *                 +-++--+                  *
> + *  *            | Integrated PHY |  YT8531S   *
> + *  *                 +-++-+                   *
> + *  ********************||******************* **
> + */
> +
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +
> +#ifdef CONFIG_PCI_MSI
> +#include <linux/pci.h>
> +#endif
> +
> +#include "yt6801.h"
> +
> +static int fxgmac_probe(struct pci_dev *pcidev, const struct
> pci_device_id *id)
> +{
> +	struct device *dev = &pcidev->dev;
> +	struct fxgmac_resources res;
> +	int i, ret;
> +
> +	ret = pcim_enable_device(pcidev);
> +	if (ret) {
> +		dev_err(dev, "%s pcim_enable_device err:%d\n",
> __func__, ret);
> +		return ret;
> +	}
> +
> +	for (i = 0; i < PCI_STD_NUM_BARS; i++) {
> +		if (pci_resource_len(pcidev, i) == 0)
> +			continue;
> +
> +		ret = pcim_iomap_regions(pcidev, BIT(i),
> FXGMAC_DRV_NAME);

This function is deprecated.

Use pcim_iomap_region() instead.

> +		if (ret) {
> +			dev_err(dev, "%s, pcim_iomap_regions
> err:%d\n",
> +				__func__, ret);
> +			return ret;
> +		}
> +		break;
> +	}
> +
> +	pci_set_master(pcidev);
> +
> +	memset(&res, 0, sizeof(res));
> +	res.irq = pcidev->irq;
> +	res.addr = pcim_iomap_table(pcidev)[i];

This function is also deprecated. You can use the function mentioned
above to obtain the mapping addr.


P.

> +
> +	return fxgmac_drv_probe(&pcidev->dev, &res);
> +}
> +
> +static void fxgmac_remove(struct pci_dev *pcidev)
> +{
> +	struct fxgmac_pdata *priv = dev_get_drvdata(&pcidev->dev);
> +	struct net_device *netdev = priv->netdev;
> +	struct device *dev = &pcidev->dev;
> +
> +	unregister_netdev(netdev);
> +	fxgmac_phy_reset(priv);
> +	free_netdev(netdev);
> +
> +	if (IS_ENABLED(CONFIG_PCI_MSI) &&
> +	    FXGMAC_GET_BITS(priv->int_flag, INT_FLAG, MSIX)) {
> +		pci_disable_msix(pcidev);
> +		kfree(priv->msix_entries);
> +		priv->msix_entries = NULL;
> +	}
> +
> +	dev_dbg(dev, "%s has been removed\n", netdev->name);
> +}
> +
> +#define MOTORCOMM_PCI_ID			0x1f0a
> +#define YT6801_PCI_DEVICE_ID			0x6801
> +
> +static const struct pci_device_id fxgmac_pci_tbl[] = {
> +	{ PCI_DEVICE(MOTORCOMM_PCI_ID, YT6801_PCI_DEVICE_ID) },
> +	{ 0 }
> +};
> +
> +MODULE_DEVICE_TABLE(pci, fxgmac_pci_tbl);
> +
> +static struct pci_driver fxgmac_pci_driver = {
> +	.name		= FXGMAC_DRV_NAME,
> +	.id_table	= fxgmac_pci_tbl,
> +	.probe		= fxgmac_probe,
> +	.remove		= fxgmac_remove,
> +};
> +
> +module_pci_driver(fxgmac_pci_driver);
> +
> +MODULE_AUTHOR("Motorcomm Electronic Tech. Co., Ltd.");
> +MODULE_DESCRIPTION(FXGMAC_DRV_DESC);
> +MODULE_LICENSE("GPL");