Re: [PATCH 1/2] dt-bindings: memory-controllers: samsung,exynos4210-srom: Enforce child props

From: Krzysztof Kozlowski
Date: Thu Mar 06 2025 - 08:51:21 EST


On 06/03/2025 14:39, Rob Herring wrote:
> Why do we need this? Any child node should have a schema which needs
> to include mc-peripheral-props.yaml if any properties from it can be
> used.

>From correctness point of view, you are right, we don't need it. However:

1. Convention was so far to have in every controller. I think this also
is easier to understand whenever one reads the bindings - clear
documentation what children on this bus should look like.

2. To clearly document from where samsung,srom-timing comes in the
required block:

https://web.git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/tree/Documentation/devicetree/bindings/memory-controllers/exynos-srom.yaml?h=dt/next#n50
Otherwise for me it is a bit confusing to require a property which is
nowhere here defined.


Best regards,
Krzysztof