Re: [RFC PATCH 3/3] treewide: pipe: Convert all references to pipe->{head,tail,max_usage,ring_size} to unsigned short

[K Prateek Nayak]

Hello Oleg, Rasmus,

On 3/6/2025 6:11 PM, Oleg Nesterov wrote:
> On 03/06, Oleg Nesterov wrote:
> > On 03/06, K Prateek Nayak wrote:
> > > @@ -272,9 +272,9 @@ pipe_read(struct kiocb *iocb, struct iov_iter *to)
> > >   	 */
> > >   	for (;;) {
> > >   		/* Read ->head with a barrier vs post_one_notification() */
> > > -		unsigned int head = smp_load_acquire(&pipe->head);
> > > -		unsigned int tail = pipe->tail;
> > > -		unsigned int mask = pipe->ring_size - 1;
> > > +		unsigned short head = smp_load_acquire(&pipe->head);
> > > +		unsigned short tail = pipe->tail;
> > > +		unsigned short mask = pipe->ring_size - 1;
> >
> > I dunno... but if we do this, perhaps we should
> > s/unsigned int/pipe_index_t instead?
> >
> > At least this would be more grep friendly.

Ack. I'll leave the typedef untouched and convert these to use
pipe_index_t. This was an experiment so see if anything breaks with u16
conversion just to get more testing on that scenario. As Rasmus
mentioned, leaving the head and tail as u32 on 64bit will lead to
better code generation.

> in any case, I think another cleanup before this change makes sense...
> pipe->ring_size is overused. pipe_read(), pipe_write() and much more
> users do not need "unsigned int mask", they can use pipe_buf(buf, slot)
> instead.

Ack. I'll add a cleanup patch ahead of this conversion. Thank you both
for taking a look.

> Oleg.

--
Thanks and Regards,
Prateek