Re: [PATCH V6 2/2] checkpatch: check format of Vec<String> in modules

[Guilherme Giacomo Simoes]

Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx> wrote:
> In any case, landing checks here is fine (as long as Joe et al.
> agree), they can be moved or removed later if needed.
The only thing bad in this check, is when the array is very very big, like:
    authors: [ 
        "author_1"
        "author_2"
        "author_3"
        "author_4"
        "author_5"
        "author_6"
        "author_8"        
		"author_9" 
        "author_10" 
        "author_11" 
        "author_12" 
        "author_13" 
        "author_14" 
        "author_15" 
        "author_16" 
        "author_17" 
    ],


if I set a new author_18, the diff will be:
         "author_15" 
         "author_16" 
         "author_17" 
+        "author_18" 
     ],
And, in this case, if I make a wrong change, like:

         "author_15" 
         "author_16" 
         "author_17" 
+        "author_18" , "author_19"
     ],
the checkpatch don't will throw a warning message, because, he don't can
perceive that he is within of array of author, firmware or alias of module!. 

I couldn't do a better check for this.. 

thoughs? 

Thanks,
Guilherme