Re: [PATCH v2 1/5] tools/nolibc: add support for openat(2)
From: Thomas Weißschuh
Date: Thu Mar 06 2025 - 12:24:25 EST
Hi Willy,
On 2025-03-04 09:11:16+0100, Willy Tarreau wrote:
> On Tue, Mar 04, 2025 at 07:58:15AM +0000, Louis Taylor wrote:
> > openat is useful to avoid needing to construct relative paths, so expose
> > a wrapper for using it directly.
>
> Reviewed the whole series, no comments from me. Let's wait for Thomas
> to double-check but for me it's OK:
>
> Acked-by: Willy Tarreau <w@xxxxxx>
Fairly happy with it, only some tiny nitpicks.
> Thomas, since you already have plenty of changes in queue, do you mind
> if I let you pick this series ?
Sure.
Also we need to send a PR to Shuah soon.
I have some patches I want to get into it.
In case you missed it:
https://lore.kernel.org/lkml/20250305-nolibc-asm-headers-v1-1-f2053def2ee7@xxxxxxxxxxxxx/
Also the removal of the constructor order validation.
Will you send a patch or should I?
Thomas