Re: [PATCH v4 14/14] cxl/acpi: Unify CFMWS memory log messages with SRAT messages

From: Dan Williams
Date: Thu Mar 06 2025 - 16:13:26 EST


Robert Richter wrote:
> CFMWS entries have a similar importance as SRAT table entries to
> describe memory regions. For CXL error analysis and memory debugging
> information of both is needed. Unify output of both messages to
> improve logging. Change the style of CFMWS message according to SRAT
> output. Also, turn messages into a dev_info() same as for SRAT.
>
> SRAT pr_info() for reference:
>
> drivers/acpi/numa/srat.c:
> pr_info("SRAT: Node %u PXM %u [mem %#010Lx-%#010Lx]%s%s\n",
>
> Signed-off-by: Robert Richter <rrichter@xxxxxxx>
> Reviewed-by: Gregory Price <gourry@xxxxxxxxxx>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> Reviewed-by: Dave Jiang <dave.jiang@xxxxxxxxx>
> Tested-by: Gregory Price <gourry@xxxxxxxxxx>
> ---
> drivers/cxl/acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

NAK on this one. If you want to add this print the best place would be
in acpi_parse_cfmws() so that it can include the PXM information and be
independent of the cxl_acpi module loading.