Re: [PATCH v3 3/4] pinctrl: samsung: add gs101 specific eint suspend/resume callbacks

From: André Draszik
Date: Thu Mar 06 2025 - 16:25:24 EST


On Thu, 2025-03-06 at 20:42 +0000, Peter Griffin wrote:
> gs101 differs to other SoCs in that fltcon1 register doesn't
> always exist. Additionally the offset of fltcon0 is not fixed
> and needs to use the newly added eint_fltcon_offset variable.
>
> Signed-off-by: Peter Griffin <peter.griffin@xxxxxxxxxx>
> Fixes: 4a8be01a1a7a ("pinctrl: samsung: Add gs101 SoC pinctrl configuration")
> Cc: stable@xxxxxxxxxxxxxxx
> ---
> Changes since v2:
> * make it clear exynos_set_wakeup(bank) is conditional on bank type (Andre)
> * align style where the '+' is placed (Andre)
> * remove unnecessary braces (Andre)
> ---
>  drivers/pinctrl/samsung/pinctrl-exynos-arm64.c | 24 ++++-----
>  drivers/pinctrl/samsung/pinctrl-exynos.c       | 70 ++++++++++++++++++++++++++
>  drivers/pinctrl/samsung/pinctrl-exynos.h       |  2 +
>  3 files changed, 84 insertions(+), 12 deletions(-)

Reviewed-by: André Draszik <andre.draszik@xxxxxxxxxx>