RE: [PATCH v3 net-next 04/13] net: enetc: add MAC filter for i.MX95 ENETC PF
From: Wei Fang
Date: Thu Mar 06 2025 - 20:23:11 EST
> On 3/4/25 8:21 AM, Wei Fang wrote:
> > +static void enetc_mac_list_del_matched_entries(struct enetc_pf *pf, u16
> si_bit,
> > + struct enetc_mac_addr *mac,
> > + int mac_cnt)
> > +{
> > + struct enetc_mac_list_entry *entry;
> > + int i;
> > +
> > + for (i = 0; i < mac_cnt; i++) {
> > + entry = enetc_mac_list_lookup_entry(pf, mac[i].addr);
> > + if (entry) {
> > + entry->si_bitmap &= ~si_bit;
> > + if (!entry->si_bitmap) {
>
>
> Minor nit: here and elsewhere you could reduce the level of indentation
> restructoring the code as:
Okay, I will improve it, thanks.
>
> if (!entry)
> continue;
>
> entry->si_bitmap &= ~si_bit;
> if (entry->si_bitmap)
> continue;
> /P