[PATCH] spi: stm32: Fix a NULL vs IS_ERR() bug

From: Charles Han
Date: Thu Mar 06 2025 - 22:25:58 EST


The devm_ioremap() function doesn't return error pointers, it may
returns NULL. Update the error checking to match.

Fixes: 79b8a705e26c ("spi: stm32: Add OSPI driver")
Signed-off-by: Charles Han <hanchunchao@xxxxxxxxxx>
---
drivers/spi/spi-stm32-ospi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-stm32-ospi.c b/drivers/spi/spi-stm32-ospi.c
index 8eadcb64f34a..a544d7897edf 100644
--- a/drivers/spi/spi-stm32-ospi.c
+++ b/drivers/spi/spi-stm32-ospi.c
@@ -835,10 +835,10 @@ static int stm32_ospi_get_resources(struct platform_device *pdev)
if (rmem) {
ospi->mm_size = rmem->size;
ospi->mm_base = devm_ioremap(dev, rmem->base, rmem->size);
- if (IS_ERR(ospi->mm_base)) {
+ if (!ospi->mm_base) {
dev_err(dev, "unable to map memory region: %pa+%pa\n",
&rmem->base, &rmem->size);
- ret = PTR_ERR(ospi->mm_base);
+ ret = -ENOMEM;
goto err_dma;
}

--
2.43.0