Re: [PATCH v3] iio: gyro: bmg160_spi: add of_match_table
From: Marcelo Schmitt
Date: Thu Mar 06 2025 - 22:48:52 EST
On 03/06, Jun Yan wrote:
> Add the missing of_match_table to bmg160_spi
> driver to enhance device tree compatibility.
>
> Signed-off-by: Jun Yan <jerrysteve1101@xxxxxxxxx>
>
> ---
LGTM
Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@xxxxxxxxx>
>
> Changes in v3
> - Adjust the content of the commit message; there are no code changes.
> - Link to v2: https://lore.kernel.org/linux-iio/20250220165001.273325-1-jerrysteve1101@xxxxxxxxx/
>
> Changes in v2
> - Fix a syntax error (a missing comma after the .of_match_table = bmg160_of_match).
> - Fix the style issues found by checkpatch.pl.
> - Link to v1: https://lore.kernel.org/linux-iio/20250219150254.24664-1-jerrysteve1101@xxxxxxxxx/
>
> ---
> drivers/iio/gyro/bmg160_spi.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/iio/gyro/bmg160_spi.c b/drivers/iio/gyro/bmg160_spi.c
> index fc2e453527b9..ac04b3b1b554 100644
> --- a/drivers/iio/gyro/bmg160_spi.c
> +++ b/drivers/iio/gyro/bmg160_spi.c
> @@ -41,9 +41,19 @@ static const struct spi_device_id bmg160_spi_id[] = {
>
> MODULE_DEVICE_TABLE(spi, bmg160_spi_id);
>
> +static const struct of_device_id bmg160_of_match[] = {
> + { .compatible = "bosch,bmg160" },
> + { .compatible = "bosch,bmi055_gyro" },
> + { .compatible = "bosch,bmi088_gyro" },
> + { }
> +};
> +
> +MODULE_DEVICE_TABLE(of, bmg160_of_match);
> +
> static struct spi_driver bmg160_spi_driver = {
> .driver = {
> .name = "bmg160_spi",
> + .of_match_table = bmg160_of_match,
> .pm = &bmg160_pm_ops,
> },
> .probe = bmg160_spi_probe,
> --
> 2.48.1
>
>