Re: [PATCH 1/3] mtd: spi-nor: explicitly include <linux/of.h>
From: Miquel Raynal
Date: Fri Mar 07 2025 - 03:15:37 EST
On 07/03/2025 at 09:09:05 +02, Tudor Ambarus <tudor.ambarus@xxxxxxxxxx> wrote:
> The core driver is using of_property_read_bool() and relies on implicit
> inclusion of <linux/of.h>, which comes from <linux/mtd/mtd.h>.
>
> It is good practice to directly include all headers used, it avoids
> implicit dependencies and spurious breakage if someone rearranges
> headers and causes the implicit include to vanish.
>
> Include the missing header.
>
> Signed-off-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx>
Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
Thanks,
Miquèl