Re: [PATCH 2/3] mtd: spi-nor: explicitly include <linux/mod_devicetable.h>

[Miquel Raynal]

Hello Tudor,

On 07/03/2025 at 09:09:06 +02, Tudor Ambarus <tudor.ambarus@xxxxxxxxxx> wrote:

> The core driver is using 'struct of_device_id' and relies on implicit
> inclusion of <linux/mod_devicetable.h>, which comes from
> <linux/of_platform.h>.

It is actually included from of.h now (since patch 1) and I wonder
whether there is a need for it to be included explicitly. As a user it
feels like "of.h" should already include whatever is needed for us (and
it's the case). Looking at the numbers, about 25% of the drivers do
include it explicitly. But either ways I'm fine.

Thanks,
Miquèl