Re: [PATCH v2 3/8] sched/deadline: Generalize unique visiting of root domains

[Juri Lelli]

On 07/03/25 11:06, Shrikanth Hegde wrote:
> 
> 
> On 3/6/25 19:40, Juri Lelli wrote:
> > Bandwidth checks and updates that work on root domains currently employ
> > a cookie mechanism for efficiency. This mechanism is very much tied to
> > when root domains are first created and initialized.
> > 
> > Generalize the cookie mechanism so that it can be used also later at
> > runtime while updating root domains. Also, additionally guard it with
> > sched_domains_mutex, since domains need to be stable while updating them
> > (and it will be required for further dynamic changes).
> > 
> > Reported-by: Jon Hunter <jonathanh@xxxxxxxxxx>
> > Fixes: 53916d5fd3c0 ("sched/deadline: Check bandwidth overflow earlier for hotplug")
> > Signed-off-by: Juri Lelli <juri.lelli@xxxxxxxxxx>

...

> > @@ -3192,7 +3195,7 @@ int sched_dl_global_validate(void)
> >   	for_each_possible_cpu(cpu) {
> 
> This has been changed in 14672f059d83f591afb2ee1fff56858efe055e5a to online
> CPUs. So patch didn't apply cleanly to me.
> 

I based the set on Linus' tree (base commit in the cover letter) as it
is modifying both sched and cgroup bits. Your fix hasn't yet be merged
into Linus' I believe.

Thanks,
Juri