Re: [PATCH net-next v6 06/12] net: pse-pd: Add support for budget evaluation strategies

[Kory Maincent]

On Thu, 6 Mar 2025 17:46:19 -0800
Jakub Kicinski <kuba@xxxxxxxxxx> wrote:

> On Tue, 04 Mar 2025 11:18:55 +0100 Kory Maincent wrote:
> > +/**
> > + * enum ethtool_pse_budget_eval_strategies - PSE budget evaluation
> > strategies.
> > + * @ETHTOOL_PSE_BUDGET_EVAL_STRAT_DISABLED: Budget evaluation strategy
> > disabled.
> > + * @ETHTOOL_PSE_BUDGET_EVAL_STRAT_STATIC: PSE static budget evaluation
> > strategy.
> > + *	Budget evaluation strategy based on the power requested during PD
> > + *	classification. This strategy is managed by the PSE core.
> > + * @ETHTOOL_PSE_BUDGET_EVAL_STRAT_DYNAMIC: PSE dynamic budget evaluation
> > + *	strategy. Budget evaluation strategy based on the current
> > consumption
> > + *	per ports compared to the total	power budget. This mode
> > is managed by
> > + *	the PSE controller.
> > + */
> > +
> > +enum ethtool_pse_budget_eval_strategies {
> > +	ETHTOOL_PSE_BUDGET_EVAL_STRAT_DISABLED	= 1 << 0,
> > +	ETHTOOL_PSE_BUDGET_EVAL_STRAT_STATIC	= 1 << 1,
> > +	ETHTOOL_PSE_BUDGET_EVAL_STRAT_DYNAMIC	= 1 << 2,
> >  };  
> 
> Leftover?

We still need these to know the PSE method but they shall not be in the uAPI
for now. I will move it out of it.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com