Re: [PATCH v3 1/6] media: dt-bindings: mt9m114: Add onnn,slew-rate DT-binding

[Mathis Foerst]

Hi Rob,

thank you for your input.

On Wed, Mar 05, 2025 at 07:08:21AM -0600, Rob Herring wrote:
> On Wed, Mar 05, 2025 at 11:14:48AM +0100, Mathis Foerst wrote:
> > The MT9M114 supports the different slew rates (0 to 7) on the output pads.
> > At the moment, this is hardcoded to 7 (the fastest rate).
> > The user might want to change this values due to EMC requirements.
> > 
> > Add the 'onnn,slew-rate' property to the MT9M114 DT-bindings for selecting
> > the desired slew rate.
> > 
> > Signed-off-by: Mathis Foerst <mathis.foerst@xxxxxx>
> > ---
> >  .../devicetree/bindings/media/i2c/onnn,mt9m114.yaml      | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml b/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml
> > index f6b87892068a..c184bc04b743 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml
> > +++ b/Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml
> > @@ -70,6 +70,15 @@ properties:
> >            - bus-type
> >            - link-frequencies
> >  
> > +  onnn,slew-rate:
> 
> Just 'slew-rate' which is already defined in the pinctrl binding.

Okay, I fixed this in v4.

> 
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    description:
> > +      Slew rate ot the output pads DOUT[7:0], LINE_VALID, FRAME_VALID and
> > +      PIXCLK. Higher values imply steeper voltage-flanks on the pads.
> > +    minimum: 0
> > +    maximum: 7
> > +    default: 7
> > +
> >  required:
> >    - compatible
> >    - reg
> > -- 
> > 2.34.1
> > 

Best regards,
Mathis Foerst