Re: [PATCH next] media: synopsys: hdmirx: Fix signedness bug in hdmirx_parse_dt()

[Dmitry Osipenko]

On 3/7/25 12:45, Dan Carpenter wrote:
> On Fri, Mar 07, 2025 at 12:36:47PM +0300, Dmitry Osipenko wrote:
>> On 3/7/25 12:30, Dan Carpenter wrote:
>>> diff --git a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
>>> index 4ffc86ad6c35..e0d3fed87a92 100644
>>> --- a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
>>> +++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
>>> @@ -154,7 +154,7 @@ struct snps_hdmirx_dev {
>>>  	bool hpd_trigger_level_high;
>>>  	bool tmds_clk_ratio;
>>>  	bool plugged;
>>> -	u32 num_clks;
>>> +	int num_clks;
>>>  	u32 edid_blocks_written;
>>>  	u32 cur_fmt_fourcc;
>>>  	u32 color_depth;
>>
>> Reviewed-by: Dmitry Osipenko <dmitry.osipenko@xxxxxxxxxxxxx>
>>
>> Would be also good to return the original error code. There is no need
>> to check for the < 1 clock, it should be the < 0 check. Can be done in a
>> separate patch later. Thanks for the fix!
> 
> I'm not very familiar with th edevm_clk_bulk_get_all() function and it's
> not documented.  But clk_bulk_get_all() does return zero, so I can see why
> people would be confused.

We will take care of it, thanks again.

-- 
Best regards,
Dmitry