Re: [PATCH v2] kunit: tool: Fix bug in parsing test plan

From: Brendan Jackman
Date: Fri Mar 07 2025 - 04:54:41 EST


On Thu, 6 Mar 2025 at 19:20, Rae Moar <rmoar@xxxxxxxxxx> wrote:
>
> A bug was identified where the KTAP below caused an infinite loop:
>
> TAP version 13
> ok 4 test_case
> 1..4
>
> The infinite loop was caused by the parser not parsing a test plan
> if following a test result line.
>
> Fix this bug to correctly parse test plan line.
>
> Signed-off-by: Rae Moar <rmoar@xxxxxxxxxx>

Hi Rae thanks again for taking a look at this. I just noticed
kunit_tool_test.py has unit tests for the parsing logic. Maybe worth
adding one for the case that was infinite looping before?

(I am not really able to offer an actual review as I couldn't really
understand the parsing code after a quick reading, but if you need it
then let me know and I'll chase you up to ask questions until I can
follow it, then I can review!)