Re: [PATCH] clocksource: timer-sp804: Fix read_current_timer() issue when clock source is not registered
From: Krzysztof Kozlowski
Date: Fri Mar 07 2025 - 06:17:14 EST
On 07/03/2025 09:10, Daniel Lezcano wrote:
>
> Hi Stephen,
>
> thanks for the proposed fix
>
> On 21/02/2025 04:46, stephen eta zhou wrote:
>> Hi daniel
>>
>> While debugging on the vexpress-v2p-ca9 platform, I discovered that the read_current_timer API wasn't functioning correctly. The issue was that the SP804 driver lacked ARM32 support and did not register read_current_timer. To add ARM32 compatibility, I’ve submitted this patch. Without it, using SP804 as the timer on ARM32 causes issues with boot_init_stack_canary when inserting the canary value into the interrupt stack, and also affects entropy generation and collection, resulting in incorrect rdseed values.
>
> It is better to put that information in the changelog and provide a
> fixed format of the patch description.
Daniel,
In case you actually consider applying this - some of the patches or
their descriptions were generated by sort of AI tools, thus approach
with caution.
It was already pointed out that patches might be a garbage output of AI.
Also they were not tested, even though what is claimed here "debugging
on ...".
Best regards,
Krzysztof