Re: [PATCH 3/3] leds: Kconfig: leds-st1202: add select for required LEDS_TRIGGER_PATTERN

[Manuel Fombuena]

On Thu, 6 Mar 2025, Lee Jones wrote:

> On Wed, 26 Feb 2025, Manuel Fombuena wrote:
> > --- a/drivers/leds/Kconfig
> > +++ b/drivers/leds/Kconfig
> > @@ -971,6 +971,7 @@ config LEDS_ST1202
> >  	depends on I2C
> >  	depends on OF
> >  	select LEDS_TRIGGERS
> > +	select LEDS_TRIGGER_PATTERN
> 
> Don't you need both?

Not sure I understand the question, sorry. The patch adds 'select 
LEDS_TRIGGER_PATTERN' to the existing 'select LEDS_TRIGGERS'. So yes, you 
need both.

If the question were meant to be 'Do you need both?' the answer would have 
also been yes. Having only 'select LEDS_TRIGGER_PATTERN' doesn't select 
LEDS_TRIGGERS, and it would be even worse because you wouldn't have any of 
them. I tried that first, in case select LEDS_TRIGGER_PATTERN implicitly 
selects LEDS_TRIGGER, but it doesn't work like that.

--
Manuel Fombuena