Re: [PATCH v4 06/17] Documentation: ABI: add wideband filter type to sysfs-bus-iio

From: Marcelo Schmitt
Date: Fri Mar 07 2025 - 07:44:30 EST


On 03/06, Jonathan Santos wrote:
> The Wideband Low Ripple filter is used for AD7768-1 Driver.
> Document wideband filter option into filter_type_available
> attribute.
>
> Signed-off-by: Jonathan Santos <Jonathan.Santos@xxxxxxxxxx>
> ---

LGTM

Reviewed-by: Marcelo Schmitt <marcelo.schmitt@xxxxxxxxxx>

FWIW, ADAQ7768-1 datasheet provides more info about what wideband should mean
for these devices.
"The wideband filter offers a filter profile similar to
an ideal brick wall filter, making it ideal for frequency analysis."
The proposed doc seems to portray that to some extent.

> v4 Changes:
> * None.
>
> v3 Changes:
> * None, since we still did not agree on a better name for this filter type.
>
> v2 Changes:
> * Removed FIR mentions.
> ---
> Documentation/ABI/testing/sysfs-bus-iio | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> index f83bd6829285..9b879e7732cd 100644
> --- a/Documentation/ABI/testing/sysfs-bus-iio
> +++ b/Documentation/ABI/testing/sysfs-bus-iio
> @@ -2291,6 +2291,8 @@ Description:
> * "sinc3+pf2" - Sinc3 + device specific Post Filter 2.
> * "sinc3+pf3" - Sinc3 + device specific Post Filter 3.
> * "sinc3+pf4" - Sinc3 + device specific Post Filter 4.
> + * "wideband" - filter with wideband low ripple passband
> + and sharp transition band.
>
> What: /sys/.../events/in_proximity_thresh_either_runningperiod
> KernelVersion: 6.6
> --
> 2.34.1
>